ashb commented on code in PR #27113:
URL: https://github.com/apache/airflow/pull/27113#discussion_r1015570248
##########
airflow/jobs/base_job.py:
##########
@@ -110,6 +111,7 @@ def __init__(self, executor=None, heartrate=None, *args,
**kwargs):
self.heartrate = heartrate
self.unixname = getuser()
self.max_tis_per_query: int = conf.getint('scheduler',
'max_tis_per_query')
+ get_listener_manager().hook.on_starting()
Review Comment:
I think this is my only question: should we combine all the hookspecs in to
a single hook, or would this be "clearer"/more maintainable in future as
```suggestion
get_listener_manager().lifecycle_hook.on_starting()
```
Possible reason for wanting this: it allows us to have conflicting names for
different scopes. I suspect this could be "we'll do it when we need it" since
it is "internal"
##########
airflow/listeners/spec/lifecycle.py:
##########
@@ -0,0 +1,38 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+from pluggy import HookspecMarker
+
+hookspec = HookspecMarker("airflow")
Review Comment:
I think each one marker should have a different name, otherwise they are
effectively the same spec aren't they? (I'm not 100% up to speed on Pluggy, so
this may _not_ be the case)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
