bolkedebruin commented on code in PR #27540:
URL: https://github.com/apache/airflow/pull/27540#discussion_r1015827097


##########
airflow/decorators/base.py:
##########
@@ -230,7 +230,7 @@ def _handle_output(self, return_value: Any, context: 
Context, xcom_push: Callabl
         if isinstance(return_value, Dataset):
             self.outlets.append(return_value)
         if isinstance(return_value, list):
-            [self.outlets.append(item) for item in return_value if 
isinstance(item, Dataset)]
+            [self.outlets.append(item) for item in return_value if 
isinstance(item, Dataset)]  # type: ignore[func-returns-value]

Review Comment:
   I think the list comprehension is more clear than a normal for loop and the 
for loop is needlessly complicated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to