o-nikolas commented on code in PR #27067:
URL: https://github.com/apache/airflow/pull/27067#discussion_r1015995590
##########
airflow/dag_processing/manager.py:
##########
@@ -1129,7 +1129,6 @@ def _kill_timed_out_processors(self):
)
Stats.decr('dag_processing.processes')
Stats.incr('dag_processing.processor_timeouts')
Review Comment:
I like a message like this, more informational rather than a TODO with a
defined time. What about this:
```
Deprecated. If and when another major version of Airflow is released, this
should be removed.
See https://github.com/apache/airflow/pull/27067#issuecomment-1289736364
```
##########
airflow/dag_processing/manager.py:
##########
@@ -1129,7 +1129,6 @@ def _kill_timed_out_processors(self):
)
Stats.decr('dag_processing.processes')
Stats.incr('dag_processing.processor_timeouts')
Review Comment:
I like a message like this, more informational rather than a TODO with a
defined time. What about this?:
```
Deprecated. If and when another major version of Airflow is released, this
should be removed.
See https://github.com/apache/airflow/pull/27067#issuecomment-1289736364
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
