dstandish commented on code in PR #27067:
URL: https://github.com/apache/airflow/pull/27067#discussion_r1016149583
##########
airflow/dag_processing/manager.py:
##########
@@ -1129,7 +1129,6 @@ def _kill_timed_out_processors(self):
)
Stats.decr('dag_processing.processes')
Stats.incr('dag_processing.processor_timeouts')
Review Comment:
all suggestions seems a bit confusing.
maybe we need to adopt a policy and say `deprecated and subject to removal
per core deprecation policy` or something...
or, short of that.... maybe just
```
Deprecated; will be removed in a future Airflow release.
```
If we don't know _when_ it will be removed, then there's not much value in
saying anything about when (i.e. "when we decide to" or "if we ever have
another major release".
Or could say
```
Deprecated; may be removed in a future Airflow release.
```
i.e. may instead of will.
But, really that's what deprecated means -- it means it _will_ be removed,
so stop using it, no? so let's just call it like it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
