potiuk commented on code in PR #27457:
URL: https://github.com/apache/airflow/pull/27457#discussion_r1016568223
##########
tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py:
##########
@@ -97,6 +97,53 @@ def setup(self, dag_maker):
patch.stopall()
+ def test_template_fields(self):
+ assert 9 == KubernetesPodOperator.template_fields.__len__()
+ KubernetesPodOperator.template_fields.__contains__('image')
+ KubernetesPodOperator.template_fields.__contains__('cmds')
+ KubernetesPodOperator.template_fields.__contains__('arguments')
+ KubernetesPodOperator.template_fields.__contains__('env_vars')
+ KubernetesPodOperator.template_fields.__contains__('labels')
+ KubernetesPodOperator.template_fields.__contains__('config_file')
+ KubernetesPodOperator.template_fields.__contains__('pod_template_file')
+ KubernetesPodOperator.template_fields.__contains__('namespace')
+
KubernetesPodOperator.template_fields.__contains__('container_resources')
Review Comment:
There are still some static checks failing that you need to fix so you can
do it along the same fix/rebase @alanatlemba .
BTW. Just to set expectations right. This is perfectly normal that PRs take
weeks, sometimes months, sometimes eve multiple months to get reviewed and
merged. This is the nature of OSS project like ours, where people review and
merge commits according to when they have time, and according to priorities.
This is something we explain in our contruibution guidelines - the nature of
the contributions is rather asynchronous and it requires patience and
persistency (a bit). We have currently 144 PRs in progress and naturally,
quality and long term maintainabilitty trump speed of merging, especially when
the changes affect really important and heavily used core parts of airflow and
are not critical (less so when it comes to integrations and even less so when
it comes to "development" tooling or documentation).
Move "slow" to go "fast" is important aspect of keeping the project in the
state that is maintainable.
Speed of merging individual PRs is not the "only" criteria that matters,
it's actually quite secondary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
