potiuk commented on PR #26486: URL: https://github.com/apache/airflow/pull/26486#issuecomment-1307781229
'And let me explain this. I also think the current way it is presented is wrong' -> yep I was referring to the fact that we do the same thing in multiple other places - almost the same prominent as the "main" page. We just have not decided what we want to to do. I am ok for now to switch everything non-taskflow to classic if we are unsure decide what to do next. Let someone proposes it on the devlist and ask for lasy consensus on it and proposes next steps. But we should agree to it and diligently review it and apply our docs to fix it, not fix "one instance" of it even if we want to fix the "main" page. I am ALL for consistency, The problem with this fix is that it changes it in one place while leaving the same "taskflow" approach in others, way worse. Just quick one: https://airflow.apache.org/docs/apache-airflow/stable/tutorial/pipeline.html - this is the tutorial where we explain how to build the pipeline. And this is FAR more inconsistent than what you see on the main page. The main page is at least consistent that it only shows the taskflow approach. Fixing it in the intro, does not solve the problem that was raised in this PR. I do not know if there are more - but it's likely. * It starts from classic approach * It then goes to show the classic operators * then it shows taskflow part * then it continues into example where it mixes taskflow and classic This is the regular "buiilding pipeline" tutorial. The first document the user gets to when you want to do something. If anyone is concerned about not surprising the user, this place (and likely few other places) should be corrected. Not the "intro" page where we are just showing "concept" of how airflow works. @bolkedebruin - do you seriously think we are solving the problem by changing the intro and leaving the tutorial with mix of concepts ? Really? In what way? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
