jedcunningham commented on code in PR #27576:
URL: https://github.com/apache/airflow/pull/27576#discussion_r1018225219
##########
airflow/www/extensions/init_appbuilder.py:
##########
@@ -215,13 +215,24 @@ def init_app(self, app, session):
else:
self.post_init()
self._init_extension(app)
+ self._swap_url_filter()
def _init_extension(self, app):
app.appbuilder = self
if not hasattr(app, "extensions"):
app.extensions = {}
app.extensions["appbuilder"] = self
+ def _swap_url_filter(self):
+ """
+ Use our url filtering util function so there is consistency between
+ FAB and Airflow routes
+ """
+ from flask_appbuilder.security import views as fab_sec_views
Review Comment:
```suggestion
from flask_appbuilder.security import views as fab_sec_views
```
##########
airflow/www/extensions/init_appbuilder.py:
##########
@@ -215,13 +215,24 @@ def init_app(self, app, session):
else:
self.post_init()
self._init_extension(app)
+ self._swap_url_filter()
def _init_extension(self, app):
app.appbuilder = self
if not hasattr(app, "extensions"):
app.extensions = {}
app.extensions["appbuilder"] = self
+ def _swap_url_filter(self):
+ """
+ Use our url filtering util function so there is consistency between
+ FAB and Airflow routes
+ """
+ from flask_appbuilder.security import views as fab_sec_views
Review Comment:
```suggestion
from flask_appbuilder.security import views as fab_sec_views
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
