ephraimbuddy commented on code in PR #27616:
URL: https://github.com/apache/airflow/pull/27616#discussion_r1020011079
##########
airflow/models/taskinstance.py:
##########
@@ -1808,13 +1808,13 @@ def handle_failure(
except Exception:
self.log.exception("Failed to send email to: %s", task.email)
- if callback and context:
- self._run_finished_callback(callback, context, callback_type)
-
if not test_mode:
session.merge(self)
session.flush()
+ if callback and context:
+ self._run_finished_callback(callback, context, callback_type)
+
Review Comment:
Can you add test? Looks like something that can be tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
