bolkedebruin commented on code in PR #27540: URL: https://github.com/apache/airflow/pull/27540#discussion_r1020162266
########## airflow/utils/json.py: ########## @@ -40,6 +43,16 @@ log = logging.getLogger(__name__) +CLASSNAME = "__classname__" +VERSION = "__version__" +DATA = "__data__" Review Comment: as mentioned `__type` is overloaded and as the deserializer receives the nested dict first it is hard to distinguish between actual type and encoding type, which is a builtin. Futhermore, I do think __var and __type are misnomers `__type` is not pythonic and `__var` is incorrect imho (it is the data of an object, not the a variable). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
