[
https://issues.apache.org/jira/browse/AIRFLOW-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876298#comment-16876298
]
ASF GitHub Bot commented on AIRFLOW-4876:
-----------------------------------------
exploy commented on pull request #5508: [AIRFLOW-4876] Making tests in CoreTest
rerunnable
URL: https://github.com/apache/airflow/pull/5508
- all related DagRun, TaskInstance and TaskFail objects are properly removed
on tear down
- replaced "models.<ModelName>" importing with "<ModelName>" direct usage
- extracted test specific DAG ids into test suit constants
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-4876
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
Contribution to any project is easier when you can quickly iterate on tests.
We have spotted that tests in CoreTest are not cleaning properly their state
in the DB while performing tear down.
Steps to reproduce: run test in CoreTest twice and some will fail
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Make CoreTest test cases rerunnable
> -----------------------------------
>
> Key: AIRFLOW-4876
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4876
> Project: Apache Airflow
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.10.4
> Reporter: Jarosław Śmietanka
> Assignee: Jarosław Śmietanka
> Priority: Minor
> Labels: test
>
> Contribution to any project is easier when you can quickly iterate on tests.
> We have spotted that tests in CoreTest are not cleaning properly their state
> in the DB while performing tear down.
> Steps to reproduce: run test in CoreTest twice and some will fail
> We have some code which solves this issue will provide PR.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
