kazanzhy commented on PR #27514: URL: https://github.com/apache/airflow/pull/27514#issuecomment-1312592946
@dstandish I understand your concerns about this PR. I must say that these changes are just returning deleted code in TrinoHook (https://github.com/apache/airflow/commit/df00436569bb6fb79ce8c0b7ca71dddf02b854ef#diff-9a702240b5127432b36cea027e9846f74943e8c20c292f4301c182c6063db880) and refactor of SnowflakeHook to use `DbApiHook.run()` instead of `SnowflakeHook.run()`. So as we saw now there's no sense in using `query_ids` for `on_kill()`. But we can save them for other reasons. I'm proposing the following steps when we will be sure that Trino `cursor.execute` for Trino is also synchronous. - remove `on_kill()` implementations for TrinoOperator and SQLExecuteQueryOperator - remove `kill_query()` implementations for TrinoHook, PrestoHook, SnowflakeHook, and DbApiHook. - rename this PR to `Merge SnowflakeHook.run and TrinoHook.run to DbApiHook.run` which will be the second part of #23971 - close issue #27314 because of impossibility to implement `on_kill()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
