mattsax commented on code in PR #27638:
URL: https://github.com/apache/airflow/pull/27638#discussion_r1020876653


##########
airflow/providers/google/cloud/utils/credentials_provider.py:
##########
@@ -332,6 +356,16 @@ def get_credentials_and_project_id(*args, **kwargs) -> 
tuple[google.auth.credent
     return _CredentialProvider(*args, **kwargs).get_credentials_and_project()
 
 
+def get_id_token_credentials(*args, **kwargs) -> 
tuple[google.auth.credentials.Credentials]:

Review Comment:
   The two seems indeed related. But `id_token_credentials.py` provide the 
credentials from [Google application default 
credentials](https://cloud.google.com/docs/authentication/application-default-credentials).
   Whereas the `credential_provider.py` already contains all the code to infer 
credentials from an Airflow Connection



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to