jedcunningham commented on code in PR #27745:
URL: https://github.com/apache/airflow/pull/27745#discussion_r1026933771
##########
airflow/models/dag.py:
##########
@@ -2822,6 +2822,11 @@ def bulk_write_to_db(
all_datasets = outlet_datasets
all_datasets.update(input_datasets)
+ # Save this set of URIs for later, since we del all_datasets before we
use this
+ datasets_to_remove = {_[0] for _ in
session.query(DatasetModel.uri).all()} - {
+ k.uri for k in all_datasets.keys()
Review Comment:
Won't this only know about datasets in a given file, thus removing all
others as "orphans"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]