mobuchowski commented on code in PR #27113:
URL: https://github.com/apache/airflow/pull/27113#discussion_r1029408755
##########
airflow/jobs/backfill_job.py:
##########
@@ -946,3 +952,12 @@ def query(result, items):
self.log.info("Reset the following %s TaskInstances:\n\t%s",
len(reset_tis), task_instance_str)
return len(reset_tis)
+
+ def notify_dagrun_state_changed(self, dag_run: DagRun, msg: str = ""):
+ if dag_run.state == DagRunState.RUNNING:
+ get_listener_manager().hook.on_dag_run_running(dag_run=dag_run,
msg=msg)
+ elif dag_run.state == DagRunState.SUCCESS:
+ get_listener_manager().hook.on_dag_run_success(dag_run=dag_run,
msg=msg)
+ elif dag_run.state == DagRunState.FAILED:
+ get_listener_manager().hook.on_dag_run_failed(dag_run=dag_run,
msg=msg)
+ # deliberately not notifying on QUEUED
Review Comment:
`QUEUED` requires running in more processes, like webserver, or
`TriggerDagRunOperator`. We can add coverage later, for now I think promising
that we'll notify about queued will be untrue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
