vincbeck commented on code in PR #27820:
URL: https://github.com/apache/airflow/pull/27820#discussion_r1029561483
##########
airflow/providers/amazon/aws/operators/redshift_cluster.py:
##########
@@ -498,22 +502,38 @@ def __init__(
wait_for_completion: bool = True,
aws_conn_id: str = "aws_default",
poll_interval: float = 30.0,
+ retry: bool = False,
+ retry_attempts: int = 10,
Review Comment:
I am not sure it is the same use case though. In [Syed's
PR](https://github.com/apache/airflow/pull/27276), the retry logic handles a
bug in `boto3`. Here it handles a valid use case: removing a Redshift cluster
that has a running operation. That's why here, in my opinion, we need a flag to
whether activate the retry. Some users might want the operator to fail in such
scenario, some might want to retry. Regarding the naming, I am happy to rename
the parameters to `attempts` and `attempt_interval` to make it more consistent
across the operators
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
