ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging
Image - Travis CI tests [Step 3/3]
URL: https://github.com/apache/airflow/pull/4938#discussion_r299378403
##########
File path: scripts/ci/kubernetes/minikube/_k8s.sh
##########
@@ -26,15 +27,15 @@ function _wait_for_ready () {
local evidence="$1"
shift
local attempts=40
- echo "Waiting till ready (count: $count): $@"
- while [[ "$count" < $("$@" 2>&1 | tail -n +2 | awk '{print $2}' | grep -c
$evidence) ]];
+ echo "Waiting till ready (count: ${count}): $*"
+ while [[ "${count}" < $("$@" 2>&1 | tail -n +2 | awk '{print $2}' | grep -c
${evidence}) ]];
do
if [[ "$attempts" = "1" ]]; then
- echo "Last run: $@"
+ echo "Last run: $*"
Review comment:
Also: why? `$@` is usually better of $# * (it makes no difference here, but
why change it?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
