potiuk commented on code in PR #27843:
URL: https://github.com/apache/airflow/pull/27843#discussion_r1029787108
##########
airflow/providers/common/sql/operators/sql.py:
##########
@@ -51,6 +51,36 @@ def _parse_boolean(val: str) -> str | bool:
raise ValueError(f"{val!r} is not a boolean-like string value")
+def _get_failed_checks(checks, col=None):
+ """
+ IMPORTANT!!! Keep it for compatibility with released 8.4.0 version of
google provider.
+
+ Unfortunately the provider used _get_failed_checks and parse_boolean as
imports and we should
+ keep those methods to avoid 8.4.0 version from failing.
+ """
+ if col:
+ return [
+ f"Column: {col}\nCheck: {check},\nCheck Values: {check_values}\n"
+ for check, check_values in checks.items()
+ if not check_values["success"]
+ ]
+ return [
+ f"\tCheck: {check},\n\tCheck Values: {check_values}\n"
+ for check, check_values in checks.items()
+ if not check_values["success"]
+ ]
+
+
+def parse_boolean(val: str) -> str | bool:
+ """
+ IMPORTANT!!! Keep it for compatibility with released 8.4.0 version of
google provider.
Review Comment:
Good question. I think there is no obvious removal condition. I could not
find a good one. 8.4.0 can be kept for a long time and and one can continue
upgrading common sql. you can easily install 8.4.0 on Airflow 2.8 and with
comon.sql 1.10 for example - theorethically should be no problem. We have no
rules for deprecating / EOL of providers. themselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
