danielhoherd commented on issue #27698: URL: https://github.com/apache/airflow/issues/27698#issuecomment-1324230207
One problem I see here is that the `--wait` flag, which exists in 3.4.0 but is deprecated in 3.6.1, has an env var `GIT_SYNC_WAIT` and is defined in helm as [`.Values.dags.gitSync.wait`](https://github.com/apache/airflow/blob/035315f5cf/chart/templates/_helpers.yaml#L217-L218). We would want to change that to `--period` with `GIT_SYNC_PERIOD` as its env var, and `.Values.dags.gitSync.wait` as its helm value. This would break existing installations. Should we have a deprecation period where we support both the deprecated `--wait` and `--period`, which correlates with how git-sync is doing it? If so, is there a standard way that Airflow does that, or should I just leave a comment saying that the option should be removed when it is removed from the git-sync command? Relevant help text (from <https://github.com/kubernetes/git-sync#manual>): ``` --period <duration>, $GIT_SYNC_PERIOD How long to wait between sync attempts. This must be at least 10ms. This flag obsoletes --wait, but if --wait is specified, it will take precedence. If not specified, this defaults to 10 seconds ("10s"). ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
