ashb commented on code in PR #27855:
URL: https://github.com/apache/airflow/pull/27855#discussion_r1030369615
##########
airflow/task/task_runner/standard_task_runner.py:
##########
@@ -42,6 +43,7 @@ def start(self):
if CAN_FORK and not self.run_as_user:
self.process = self._start_by_fork()
else:
+ get_listener_manager().hook.on_starting(component=self)
Review Comment:
Hmmm, this one isn't "right", Calling it here puts it in the wrong process
-- or at least the active memory of the process is about to get replace by the
`exec` syscall that this path takes. And this will never get the before_stop
called either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
