ashb commented on code in PR #27849:
URL: https://github.com/apache/airflow/pull/27849#discussion_r1030259162
##########
tests/api_connexion/endpoints/test_task_instance_endpoint.py:
##########
@@ -380,18 +380,13 @@ def
test_should_respond_200_task_instance_with_sla_and_rendered(self, session):
def test_should_respond_200_mapped_task_instance_with_rtif(self, session):
"""Verify we don't duplicate rows through join to RTIF"""
tis = self.create_task_instances(session)
- session.query()
- ti = tis[0]
- ti.map_index = 1
Review Comment:
You removed the mapped Ti test. We probably shouldn't.
##########
tests/api_connexion/endpoints/test_dag_run_endpoint.py:
##########
@@ -1421,7 +1421,7 @@ def test_should_respond_200(self, dag_maker, session):
"execution_date": dr.execution_date.isoformat(),
"external_trigger": False,
"logical_date": dr.logical_date.isoformat(),
- "start_date": dr.logical_date.isoformat(),
Review Comment:
Okay this is right due to this code, and it shouldn't have haver been
passing before! (it was missing a flush or a proper refresh before.)
https://github.com/apache/airflow/blob/fb7c6afc8cb7f93909bd2e654ea185eb6abcc1ea/airflow/models/taskinstance.py#L276-L278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
