vandonr-amz commented on code in PR #27786:
URL: https://github.com/apache/airflow/pull/27786#discussion_r1031797200
##########
airflow/providers/amazon/aws/hooks/sagemaker.py:
##########
@@ -647,28 +649,28 @@ def describe_endpoint(self, name: str) -> dict:
def check_status(
self,
- job_name: str,
+ resource_name: str,
Review Comment:
ah that's a good point... I can keep it as job_name to avoid that, there is
no strong need to rename it.
I can also add a small comment about the fact that it can be used to check
more than jobs.
tbh I think this method should have been private, it's mostly a helper, only
used in `wait_for_completion` cases, but now it's too late to change that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
