norm commented on code in PR #27829:
URL: https://github.com/apache/airflow/pull/27829#discussion_r1032208801
##########
dev/breeze/src/airflow_breeze/utils/confirm.py:
##########
@@ -98,3 +98,20 @@ def user_confirm(
if quit_allowed:
return Answer.QUIT
sys.exit(1)
+
+
+def user_confirm_bool(
Review Comment:
Observation: At first glance having the name end `…_bool` didn't make me
think it would do any more than return True/False, so having it exit on
no/abort was unexpected. But I am also struggling to come up with an alternate
name so this isn't a call to action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
