Taragolis commented on code in PR #27381:
URL: https://github.com/apache/airflow/pull/27381#discussion_r1032389445
##########
airflow/jobs/local_task_job.py:
##########
@@ -83,6 +113,14 @@ def signal_handler(signum, frame):
self.task_runner.terminate()
self.handle_task_exit(128 + signum)
+ def segfault_signal_handler(signum, frame):
+ """Setting sigmentation violation signal handler"""
+ self.log.critical(SIGSEGV_MESSAGE)
+ self.task_runner.terminate()
+ self.handle_task_exit(128 + signum)
+ raise AirflowException("Segmentation Fault detected.")
+
+ signal.signal(signal.SIGSEGV, segfault_signal_handler)
Review Comment:
Third attempt for detect segfault and show info for end users by handling
SIGSEGV signal.
@potiuk @uranusjr I'm not sure is this correct way to terminate task runner?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
