potiuk commented on code in PR #27912:
URL: https://github.com/apache/airflow/pull/27912#discussion_r1032392734
##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -246,40 +270,48 @@ def run(
:param return_last: Whether to return result for only last statement
or for all after split
:return: return only result of the ALL SQL expressions if handler was
provided.
"""
- self.scalar_return_last = isinstance(sql, str) and return_last
+ self.descriptions = []
+
if isinstance(sql, str):
if split_statements:
- sql = self.split_sql_string(sql)
+ sql_list: Iterable[str] = self.split_sql_string(sql)
else:
- sql = [sql]
+ sql_list = [sql] if sql.strip() else []
Review Comment:
I added strip() here to cover the case when sql is empty string (see tests
for empty).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
