dwreeves opened a new pull request, #27920:
URL: https://github.com/apache/airflow/pull/27920
Closes: #26571
This PR contains the following:
* Implemented the following bullet points outlined in #26571:
* Removed `ast.literal_eval` for deserializing JSON secrets.
* Removed `full_url_mode` kwarg entirely. JSONs are now automatically
detected.
* Removed requirement that `get_conn_value()` must return a URI.
* **Note that this means that the AWS provider package will no
longer work with Airflow 2.2.x and requires 2.3.0 or greater.**
* Removed requirement that secrets must be URL-encoded when stored as
JSONs.
* **Note that this change will be breaking for some users, although
the current AWS provider package should be raising `DeprecationWarning`s for
users who will be affected.**
* Set `login` as the default name for the login with the JSON
standardization thing in `_standardize_secret_keys`.
* Updated docs to reflect these changes.
* Removed all references to full URL mode.
* Provided what I believe to be much clearer examples of AWS Secrets
Manager setup.
* Moved the docs to being more consistent with Airflow's base secrets
API, e.g. `login` instead of `user`, `password` instead of `pass`, etc. + I
wrote a note saying that using these names is encouraged.
* I also raised the header levels a little bit across the doc; they were
very low!
As stated in #26571, the intent with this PR (as well as the one leading up
to it that added a bunch of deprecation warnings) is to make it so the secret
values accepted by the `SecretsManagerBackend` are a strict superset of what is
allowed by the `BaseSecretsBackend`, and behave in the same way, so as to
adhere to the principle of behavioral subtyping.
For both the reasons stated above in bold-- this is incompatible with
Airflow 2.2.x, and a small number of users will be hit by backwards
incompatibility after implementing this change-- merging this PR would require
a major version bump of the Amazon provider package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
