vincbeck commented on code in PR #27892: URL: https://github.com/apache/airflow/pull/27892#discussion_r1032593993
########## airflow/api_internal/internal_api_call.py: ########## @@ -0,0 +1,84 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import inspect +import json +from typing import Callable, TypeVar + +import requests + +from airflow.configuration import conf +from airflow.exceptions import AirflowException +from airflow.serialization.serialized_objects import BaseSerialization +from airflow.typing_compat import ParamSpec + +PS = ParamSpec("PS") +RT = TypeVar("RT") + +_use_internal_api = conf.get("core", "database_access_isolation") +_internal_api_url = conf.get("core", "database_api_url") + +_internal_api_endpoint = _internal_api_url + "/internal/v1/rpcapi" +if not _internal_api_endpoint.startswith("http://";): + _internal_api_endpoint = "http://"; + _internal_api_endpoint Review Comment: Should not we raise an exception in such case? I am scared that if you make a typo in `database_api_url` and for instance set the value as `http//......` (the `:` is missing), you end up having `_internal_api_endpoint` set to `http://http//.......`. I rather be strict on the data format and complain if it does not fit the schema than trying to fix it and end up in a worse situation than it is originally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
