alexott commented on code in PR #27912:
URL: https://github.com/apache/airflow/pull/27912#discussion_r1032763444
##########
airflow/providers/common/sql/operators/sql.py:
##########
@@ -190,11 +189,17 @@ class SQLExecuteQueryOperator(BaseSQLOperator):
Executes SQL code in a specific database
:param sql: the SQL code or string pointing to a template file to be
executed (templated).
File must have a '.sql' extensions.
+
+ When implementing a specific Operator, you can also implement
`_process_output` method in the
Review Comment:
should we use double backquotes in docstrings?
##########
airflow/providers/common/sql/CHANGELOG.rst:
##########
@@ -32,7 +32,9 @@ This release fixes a few errors that were introduced in
common.sql operator whil
* ``_process_output`` method in ``SQLExecuteQueryOperator`` has now consistent
semantics and typing, it
can also modify the returned (and stored in XCom) values in the operators
that derive from the
``SQLExecuteQueryOperator``).
-* last description of the cursor whether to return scalar values are now
stored in DBApiHook
+* descriptions of all returned results are stored as descriptions property in
the DBApiHook
Review Comment:
(could be done later) maybe it would be a bit easier to read if
`descriptions` and `last_description` are formatted as code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
