potiuk commented on PR #27946: URL: https://github.com/apache/airflow/pull/27946#issuecomment-1329331835
The mypy change is in https://github.com/apache/airflow/pull/27962/ - overall it's even more code eventually (multiple stub files generated, and I also had to handle black formatting of the resulting code as well as nicely handle cases where whole python files would be deleted (or renamed). I think though it is totally worth - it also because the .pyi files will be part of the provider package and you will not only check it during our pre-commits but also any of the users of common.sql provider who uses mypy will have errors when using internal methods. So ultimately I think this was a great suggestion @ashb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
