o-nikolas commented on code in PR #27941:
URL: https://github.com/apache/airflow/pull/27941#discussion_r1033858771


##########
airflow/executors/base_executor.py:
##########
@@ -69,6 +69,8 @@ class BaseExecutor(LoggingMixin):
     job_id: None | int | str = None
     callback_sink: BaseCallbackSink | None = None
 
+    is_local: bool = False

Review Comment:
   We should add a simple unit test that asserts that this field is present 
with the default that we expect (and likewise add one for the specific 
executors which override it to ensure we get the expected value there). If 
someone were to accidentally (or misguidedly change it with intention) modify 
one of these we'd like tests to fail.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to