bbovenzi opened a new pull request, #27987:
URL: https://github.com/apache/airflow/pull/27987

   To calculate all the independent graphs in the datasets view, we start with 
a graph for each edge with no upstreams and then merge them once we find a 
common edge. This wasn't merging nodes correctly, sometimes the same node was 
added over and over for every edge it had. I found a patch for the fix, but 
then realized that the logic was quite brittle and decided to refactor.
   We only need the edges to figure out the graph, so we just recursively 
iterate over those. Using `.reduce` and `.map` instead of weird 
`indexesToRemove` objects. Once all the edges are placed, we add the nodes.
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to