bbovenzi commented on code in PR #27805:
URL: https://github.com/apache/airflow/pull/27805#discussion_r1035305777
##########
airflow/www/static/js/trigger.js:
##########
@@ -20,13 +20,24 @@
/* global document, CodeMirror, window */
const textArea = document.getElementById('json');
+const recentConfigList = document.getElementById('recent_configs');
const minHeight = 300;
const maxHeight = window.innerHeight - 450;
const height = maxHeight > minHeight ? maxHeight : minHeight;
CodeMirror.fromTextArea(textArea, {
lineNumbers: true,
- mode: { name: 'javascript', json: true },
+ mode: {
+ name: 'javascript',
+ json: true,
+ },
gutters: ['CodeMirror-lint-markers'],
lint: true,
-}).setSize(null, height);
+})
+ .setSize(null, height);
+
+function setRecentConfig(e) {
+ document.querySelector('.CodeMirror').CodeMirror.setValue(e.target.value);
Review Comment:
I wonder if we should try to format the config JSON so it doesn't appear as
a single line
```
function setRecentConfig(e) {
let { value } = e.target;
try {
const json = JSON.parse(value);
value = JSON.stringify(json, null, 2);
} catch (err) {
console.err(err);
}
document.querySelector('.CodeMirror').CodeMirror.setValue(value);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
