[
https://issues.apache.org/jira/browse/AIRFLOW-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16877290#comment-16877290
]
ASF GitHub Bot commented on AIRFLOW-4885:
-----------------------------------------
potiuk commented on pull request #5518: [AIRFLOW-4885] Add virtualenv dependency
URL: https://github.com/apache/airflow/pull/5518
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-4885
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
We have no "virtualenv" dependency defined, but it is needed by
PythonVirtualenvOperator - it nieeds virtualenv even if migrated to Python 3.x
because it needs to run other python versions (even 2.7) - so venv does not
help.
It was not detected before because current CI installs virtualenv. The new
CI - as implemented in AIRFLOW-3718 does not install virtualenv and it was
detected then.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
It's already tested but in the new CI test fails without having virtualenv
in setup.py
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Virtualenv dependency is needed by PythonVirtualenvOperator
> -----------------------------------------------------------
>
> Key: AIRFLOW-4885
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4885
> Project: Apache Airflow
> Issue Type: Bug
> Components: dependencies
> Affects Versions: 1.10.3, 1.10.4
> Reporter: Jarek Potiuk
> Priority: Major
>
> We have no "virtualenv" dependency defined, but it is needed by
> PythonVirtualenvOperator - it nieeds virtualenv even if migrated to Python
> 3.x because it needs to run other python versions (even 2.7) - so venv does
> not help.
> It was not detected before because current CI installs virtualenv. The new CI
> - as implemented in AIRFLOW-3718 does not install virtualenv and it was
> detected then.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
