potiuk commented on code in PR #28006:
URL: https://github.com/apache/airflow/pull/28006#discussion_r1036460841
##########
airflow/providers/snowflake/hooks/snowflake.py:
##########
@@ -369,15 +369,19 @@ def run(
with closing(self.get_conn()) as conn:
self.set_autocommit(conn, autocommit)
- # SnowflakeCursor does not extend ContextManager, so we have to
ignore mypy error here
- with closing(conn.cursor(DictCursor)) as cur: # type:
ignore[type-var]
Review Comment:
BTW. I also added the CHANGELOG entry on how I see the communication about
the breaking changes. We will yank 4.0.0/4.0.1 (they has not been released yet
in any Airflow and it is out just few days and people reported it broken and
downgraded it anyway). Recent changing extras was breaking anyway so we would
not mess around with multiple braking release.
This is the easiest way to come clean out of that @dstandish - unless you
have other ways of handling it now, I am all ears (and waiting for PRs),
because both 4.0.1 and 4.0.0 are broken and we **need** to do something **now**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
