IAL32 commented on PR #28005: URL: https://github.com/apache/airflow/pull/28005#issuecomment-1333883247
@Taragolis I have added several tests, and isolated tag updating by adding a `update_tags` method. This is because when calling `glue_client.get_crawler` the `Tags` is not present, even if tags are correctly set for the given Crawler. Furthermore, the `update_crawler` does *not* accept the `Tags` parameter: https://docs.aws.amazon.com/glue/latest/webapi/API_UpdateCrawler.html thus, making it impossible to update the tags for crawlers using conventional methods. In my solution, I call `tag_resource` (https://docs.aws.amazon.com/glue/latest/webapi/API_TagResource.html) when adding/replacing existing tags, and `untag_resource` (https://docs.aws.amazon.com/glue/latest/webapi/API_UntagResource.html) when deleting tags. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
