jedcunningham commented on code in PR #28034:
URL: https://github.com/apache/airflow/pull/28034#discussion_r1037668526
##########
chart/templates/statsd/statsd-deployment.yaml:
##########
@@ -115,6 +115,10 @@ spec:
- name: config
mountPath: /etc/statsd-exporter/mappings.yml
subPath: mappings.yml
+{{- if .Values.statsd.env}}
+ env:
+ {{- include "container_extra_envs" (list . .Values.statsd.env) |
indent 10 }}
Review Comment:
Since this isn't an Airflow container, we don't need to use this helper here.
##########
chart/values.schema.json:
##########
@@ -4023,6 +4023,27 @@
"default": null,
"x-docsSection": null
},
+ "env": {
+ "description": "Add additional env vars to stats.",
+ "type": "array",
+ "default": [],
+ "items": {
+ "type": "object",
+ "properties": {
+ "name": {
+ "type": "string"
+ },
+ "value": {
+ "type": "string"
+ }
+ },
+ "required": [
+ "name",
+ "value"
+ ],
+ "additionalProperties": false
Review Comment:
```suggestion
"$ref": "#/definitions/io.k8s.api.core.v1.EnvVar"
```
And we can allow "normal" env vars here because of that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
