ferruzzi commented on code in PR #28039:
URL: https://github.com/apache/airflow/pull/28039#discussion_r1038468940
##########
tests/providers/amazon/aws/hooks/test_glacier.py:
##########
@@ -47,25 +47,21 @@ def test_retrieve_inventory_should_return_job_id(self,
mock_conn):
assert job_id == result
@mock.patch("airflow.providers.amazon.aws.hooks.glacier.GlacierHook.get_conn")
- def test_retrieve_inventory_should_log_mgs(self, mock_conn):
+ def test_retrieve_inventory_should_log_mgs(self, mock_conn, caplog):
# given
Review Comment:
Yeah, every time I try do add some new code I find a dozen older bits I'd
love to redo in the process. Like why are we mocking get_conn in every test
instead of making one fixture to do it? I'll take care of that one at some
point. Can't fix it all at once :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
