vincbeck commented on PR #27947: URL: https://github.com/apache/airflow/pull/27947#issuecomment-1335815203
> > For avoid any further regression error I would suggest move tests this methods from operator `tests/providers/amazon/aws/operators/test_redshift_data.py` to hook `tests/providers/amazon/aws/hooks/test_redshift_data.py` and test that this operator call expected hook methods. > > Thanks, yes I copied the tests from operator to hook, and left operator tests in place while we still have the deprecated public methods there. Although this is fine, as mentioned by @Taragolis I would update operator tests to only check that the hook is correctly called. We should not check in operators tests, the implementation of the hook -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
