mlnsharma commented on PR #27802: URL: https://github.com/apache/airflow/pull/27802#issuecomment-1336181929
Hi @bdsoha @potiuk I fixed the code as per comments, implemented a new log_containers option, added a couple of unit tests for the same. When I was testing with 'get_logs=False' option, I noticed that the airflow-xcom-sidecar container was not getting started and pod changed to NotReady state. I fixed the await_container_completion code and then it started working, I included that change also in the PR. Can you please run the tests workflow? and review my commits? PS: I am not sure how to squash all my commits in the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
