hterik commented on code in PR #27611:
URL: https://github.com/apache/airflow/pull/27611#discussion_r1039269266
##########
airflow/executors/kubernetes_executor.py:
##########
@@ -256,7 +256,10 @@ def __init__(
def run_pod_async(self, pod: k8s.V1Pod, **kwargs):
"""Runs POD asynchronously"""
- pod_mutation_hook(pod)
+ try:
+ pod_mutation_hook(pod)
+ except Exception as e:
+ raise PodMutationHookException(e)
Review Comment:
Oh sorry, maybe `raise PodMutationHookException(e) from e` in that case ;)
That will have best of both worlds. But yeah, i think the difference is minor
and i don't think it has any logical difference other than the log message in
between the two tracebacks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
