ashb commented on a change in pull request #5525: [AIRFLOW-4890] Fix Log link
in TaskInstance's View for Non-RBAC
URL: https://github.com/apache/airflow/pull/5525#discussion_r300081249
##########
File path: airflow/models/taskinstance.py
##########
@@ -376,12 +377,13 @@ def log_filepath(self):
def log_url(self):
iso = quote(self.execution_date.isoformat())
base_url = configuration.conf.get('webserver', 'BASE_URL')
- return base_url + (
- "/log?"
- "execution_date={iso}"
- "&task_id={task_id}"
- "&dag_id={dag_id}"
- ).format(iso=iso, task_id=self.task_id, dag_id=self.dag_id)
+
+ relative_url =
"/log?execution_date={iso}&task_id={task_id}&dag_id={dag_id}".format(
+ iso=iso, task_id=self.task_id, dag_id=self.dag_id)
Review comment:
Can you url-quote these three please?
```suggestion
iso=quote_plus(iso), task_id=quote_plus(self.task_id),
dag_id=quote_plus(self.dag_id))
```
And
```
from six.moves.urllib.parse import quote_plus
```
at the top
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
