[
https://issues.apache.org/jira/browse/AIRFLOW-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878026#comment-16878026
]
ASF GitHub Bot commented on AIRFLOW-4892:
-----------------------------------------
ashb commented on pull request #5527: [AIRFLOW-4892] Fix connection creation
via UIs
URL: https://github.com/apache/airflow/pull/5527
## Jira
- [x] https://issues.apache.org/jira/browse/AIRFLOW-4892
### Description
- [x] The form validation for classic UI was failing with an error on the
(most often hidden) Num Retries field.
RBAC was failing because the form wasn't rendering due to a typo in a
cherry-pick/backport to www_rbac.
Both of these apply to the release branch only as they were the result of
me back-porting PRs from master that had in-sufficient test. I have a separate
PR to add more tests to the connection form on master.
### Tests
- [x] Added some tests.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Creation of Connections via UI fails in 1.10.4rc2
> -------------------------------------------------
>
> Key: AIRFLOW-4892
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4892
> Project: Apache Airflow
> Issue Type: Bug
> Components: ui
> Affects Versions: 1.10.4
> Reporter: Felix Uellendall
> Assignee: Ash Berlin-Taylor
> Priority: Major
> Fix For: 1.10.4
>
>
> Via classic UI: When trying to create/save a new connection. The form only
> reloads without saving the connection.
> With RBAC: Error when rendering the connections form:
> {noformat}
> jinja2.exceptions.UndefinedError: 'airflow.www_rbac.forms.ConnectionForm
> object' has no attribute 'extra__grpc__credentials_pem_file'
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
