[
https://issues.apache.org/jira/browse/AIRFLOW-4894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878242#comment-16878242
]
ASF GitHub Bot commented on AIRFLOW-4894:
-----------------------------------------
zzlbuaa commented on pull request #5531: [AIRFLOW-4894]Add hook and operator
for GCP DLP
URL: https://github.com/apache/airflow/pull/5531
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW-4894) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Add a hook and operator for GCP Data Loss Prevention(DLP).
DLP API allows users to inspect or redact sensitive data in text contents or
GCP storage locations.
The hook includes the following APIs that addresses most use cases in
sensitive data inspection and redaction:
- inspect/deidentify/reidentify for content items
- create/delete/get/list/patch for inspectTemplates and storedInfoTypes
- create/list/get/delete/cancel for dlpJobs
Since the dlp job are long-running and created asynchronously, the operator
creates a dlp job(for storage inspection or risk analysis), keeps polling its
status and waits for it to be done or canceled/deleted.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
See tests/contrib/hooks/test_gcp_data_loss_prevention_hook.py
and tests/contrib/operators/test_gcp_run_dlp_job.py
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add hook and operator for GCP Data Loss Prevention API
> ------------------------------------------------------
>
> Key: AIRFLOW-4894
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4894
> Project: Apache Airflow
> Issue Type: New Feature
> Components: api, gcp, hooks, operators, tests
> Affects Versions: 1.10.3
> Reporter: Zhengliang Zhu
> Assignee: Zhengliang Zhu
> Priority: Minor
>
> Add a hook and operator to manipulate and use Google Cloud Data Loss
> Prevention(DLP) API. DLP API allow users to inspect or redact sensitive data
> in text contents or GCP storage locations.
> The hook includes the following APIs, implemented with Google service
> discovery API:
> * inspect/deidentify/reidentify for content:
> [https://cloud.google.com/dlp/docs/reference/rest/v2/projects.content]
> * create/delete/get/list/patch for inspectTemplates:
> [https://cloud.google.com/dlp/docs/reference/rest/v2/organizations.inspectTemplates],
>
> [https://cloud.google.com/dlp/docs/reference/rest/v2/projects.inspectTemplates]
> * create/delete/get/list/patch for storedInfoTypes:
> [https://cloud.google.com/dlp/docs/reference/rest/v2/organizations.storedInfoTypes],
>
> [https://cloud.google.com/dlp/docs/reference/rest/v2/projects.storedInfoTypes]
> * create/list/get/delete/cancel for dlpJobs:
> [https://cloud.google.com/dlp/docs/reference/rest/v2/projects.dlpJobs]
> The operator creates a long-running dlp job (for storage inspection or risk
> analysis), keeps polling its status and waits for it to be done or
> canceled/deleted.
> Apart from unit tests, also tested locally in DAG level(not included in PR).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
