Taragolis commented on code in PR #28187:
URL: https://github.com/apache/airflow/pull/28187#discussion_r1043159197
##########
airflow/providers/amazon/aws/hooks/redshift_sql.py:
##########
@@ -44,6 +58,10 @@ class RedshiftSQLHook(DbApiHook):
hook_name = "Amazon Redshift"
supports_autocommit = True
+ def __init__(self, *args, aws_conn_id: str = "aws_default", **kwargs) ->
None:
Review Comment:
`aws_conn_id` might be None, in this case default `boto3` strategy will use
(usual EC2 Instance Profile or ECS Execution Role)
##########
airflow/providers/amazon/aws/hooks/redshift_sql.py:
##########
@@ -62,6 +80,9 @@ def _get_conn_params(self) -> dict[str, str | int]:
conn_params: dict[str, str | int] = {}
+ if conn.extra_dejson.get("iam", False):
Review Comment:
I'm worry that `redshift-connector` also might use same connection
parameter, see list available parameters:
https://github.com/aws/amazon-redshift-python-driver#connection-parameters
As result it might broke someone connections
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
