potiuk commented on code in PR #28234:
URL: https://github.com/apache/airflow/pull/28234#discussion_r1043789573
##########
airflow/providers/microsoft/azure/hooks/wasb.py:
##########
@@ -385,7 +385,7 @@ def upload(
return blob_client.upload_blob(data, blob_type, length=length,
**kwargs)
def download(
- self, container_name, blob_name, offset: int, length: int, **kwargs
+ self, container_name, blob_name, offset: int | None = None, length:
int | None = None, **kwargs
Review Comment:
I am afraid #25426 was a mistake.
They simply added type-hints but left None as default. They simply use
"implict optional" and we don't use it.
Implicit optional is a setting we have to add in
https://github.com/apache/airflow/blob/1eaedc8ae85dbbfaaa402f9936304be51de98f88/setup.cfg#L191
to add azure-storage to list of other azure libraries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
