dstandish opened a new pull request, #28237: URL: https://github.com/apache/airflow/pull/28237
Because of the way that the task log handler reads from running k8s executor pods, we must keep pod name <= 63 characters. The handler gets pod name from ti.hostname. TI hostname is derived from the container hostname, which is truncated to 63 characters. We could lift this limit by using label selectors instead of pod name to find the pod. But for now, easy enough to keep limited to 63. Since we limit to 63 in the code, we can remove the logic to find the matching pod when length is >= 63. --- Note: Recently I made changes that allowed for longer pod name, and take up less space on the random part, and allow hyphens. At the time it wasn't clear why the pod id length had to be limited. But I think the reason is this task log issue. So we restore the length limit here, while still retaining the other improvements. And we make clear in the place where we limit what is the reason for the limit. And we remove the code to handle longer limit since it's not needed. For KPO, we can keep the longer name since hostname is not used for pod id. (there we use labels) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
