blag commented on code in PR #28238:
URL: https://github.com/apache/airflow/pull/28238#discussion_r1043828568
##########
airflow/executors/base_executor.py:
##########
@@ -128,6 +128,7 @@ def queue_task_instance(
pool=pool,
pickle_id=pickle_id,
cfg_path=cfg_path,
+ interactive=self.__class__.__name__ == "KubernetesExecutor",
Review Comment:
Given
[AIP-51](https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-51+Removing+Executor+Coupling+from+Core+Airflow),
can we tweak how this check is implemented? Maybe have a
`supports_interactive` attribute on BaseExecutor? It just seems weird to
require a base class to have knowledge about subclasses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
