o-nikolas commented on code in PR #28161:
URL: https://github.com/apache/airflow/pull/28161#discussion_r1043906313


##########
airflow/executors/base_executor.py:
##########
@@ -373,6 +374,62 @@ def validate_airflow_tasks_run_command(command: list[str]) 
-> tuple[str | None,
             return dag_id, task_id
         return None, None
 
+    @staticmethod
+    def _get_log_retrieval_url(ti: TaskInstance, log_relative_path: str) -> 
str:
+        url = urljoin(
+            f"http://{ti.hostname}:{conf.get('logging', 
'WORKER_LOG_SERVER_PORT')}/log/",
+            log_relative_path,
+        )
+        return url
+
+    def get_task_log(self, ti: TaskInstance, log_relative_path: str) -> str | 
tuple[str, dict[str, bool]]:

Review Comment:
   Perfect, thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to