ashb commented on a change in pull request #5516: [AIRFLOW-4884] Roll up import_errors in UI URL: https://github.com/apache/airflow/pull/5516#discussion_r300344054
########## File path: airflow/www/templates/appbuilder/flash.html ########## @@ -0,0 +1,68 @@ +<!-- Adapted from: https://github.com/dpgaspar/Flask-AppBuilder/blob/master/flask_appbuilder/templates/appbuilder/flash.html --> + +<link rel="stylesheet" type="text/css" href="{{ url_for('static', filename='css/flash.css') }}"> + +<!-- Split array into two arrays: one about Broken DAG, another normal alert --> +{% with messages = get_flashed_messages(with_categories=true) %} + {% if messages %} + + {% set broken_dag_messages = [] %} + {% set other_messages = [] %} + + {% for category, m in messages %} + {% if m.startswith('Broken DAG') %} Review comment: I'd say lets be more specific and call categorise them as `dag_import_error`. (It would be nice to _also_ show the stacktrace of the the import errors, but to make that not be spammy visually we need to collapse the stacktrace for each import error too.) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
