pierrejeambrun commented on issue #28276: URL: https://github.com/apache/airflow/issues/28276#issuecomment-1345255738
I think you resumed pretty well the options we have. I naively went for 1) in a quickfix https://github.com/apache/airflow/pull/28277 for `is_local`. (I would be glad to propagate this to other executor and attribute (supports_ad_hoc_ti_run), if we chose to go this way) I don't have a lot of context/background on custom executor and how our users leverage them. I would say that for maintainability, having third party executor extends the base executor would be much easier. (and make sense to me). Otherwise we have to keep in mind that 'Any' type can be passed as an executor to airflow core, and this is pretty ugly to handle. (would require changing type and using 'hasattr' everywhere in the codebase where we have an 'Executor' type). I would lean for 1 with a follow up task to make all core airflow executor extends the base class, and asking custom executor to also inherit this. (but the breaking change is a fair concern) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
