[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #27953: Add timezone to dags in main screen

Sat, 10 Dec 2022 12:52:34 -0800 


pierrejeambrun commented on code in PR #27953:
URL: https://github.com/apache/airflow/pull/27953#discussion_r1045134838


##########
airflow/models/dag.py:
##########
@@ -3204,6 +3204,13 @@ def __init__(self, concurrency=None, **kwargs):
     def __repr__(self):
         return f"<DAG: {self.dag_id}>"
 
+    @property
+    def schedule_description(self) -> str | None:

Review Comment:
   Type is wrong here I believe:
   ```suggestion
       def schedule_description(self) -> str:
   ```



##########
airflow/models/dag.py:
##########
@@ -3204,6 +3204,13 @@ def __init__(self, concurrency=None, **kwargs):
     def __repr__(self):
         return f"<DAG: {self.dag_id}>"
 
+    @property
+    def schedule_description(self) -> str | None:

Review Comment:
   This is not enough, dataset triggered dag also have a schedule_interval as a 
string, I think we need to check the self.timetable attribute.
   
![image](https://user-images.githubusercontent.com/14861206/206874517-4ec14250-3da2-492d-ac80-d86cd0582abd.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to